Ticket #176 (new enhancement)

Opened 3 years ago

Last modified 2 years ago

[PATCH] Handle Obsoletes in repoclosure

Reported by: mschwendt Assigned to: skvidal
Priority: major Milestone:
Component: yum-utils Version:
Keywords: Cc:

Description

yum-utils' repoclosure doesn't evaluate "Obsoletes" tags, not even when running it with option -n. It would be important to add such a feature, so the Rawhide build report would detect such problems.

Attached is a patch that handles Obsoletes similar to how it's done in the modified Fedora Extras repoclosure.

[Whether to enable this feature only for option -n or whether to make -n the default (and drop it from repoclosure) remains to be discussed. I would vote for dropping -n. However, Yum "install" doesn't evalulate Obsoletes either while Yum "update" does. That results in weird update breakage when encountering bad Obsoletes/Provides pairs, for example.]

Attachments

repoclosure-obsoletes.diff (2.1 kB) - added by mschwendt on 08/05/09 10:57:47.
diff against yum-utils 1.1.22
repoclosure-with-obsoletes.patch (1.6 kB) - added by skvidal on 08/31/09 18:31:19.

Change History

08/05/09 10:57:47 changed by mschwendt

  • attachment repoclosure-obsoletes.diff added.

diff against yum-utils 1.1.22

08/28/09 21:00:37 changed by skvidal

I made a slightly different patch - see the attached - see if you can find a case where it breaks.

thanks

08/29/09 07:41:36 changed by mschwendt

Hmm, to delete items from the packageSack directly looks promising, but:

I think you still need to delete also from the "pkgs" list -- or regenerate that list from the pkgSack. Or else the "for pkg in pkgs:" loop just below the patch processes obsolete packages and tries to resolve them.

08/31/09 18:31:05 changed by skvidal

You're right - new patch which regenerates the list and merges the code together a bit better

08/31/09 18:31:19 changed by skvidal

  • attachment repoclosure-with-obsoletes.patch added.