Ticket #6 (closed defect: fixed)

Opened 3 years ago

Last modified 3 months ago

changelog entries in metadata are disordered

Reported by: mschwendt Assigned to: james
Priority: major Milestone:
Component: yum Version:
Keywords: Cc:

Description

This is the problem that causes repodiff to generated broken changelog diff summaries in the Rawhide build report.

Not sorting the changelog entries at all should fix it. (Even if it were necessary to reverse them, this could be done with a stack).

Attachments

packages.diff (431 bytes) - added by mschwendt on 12/19/08 13:54:59.
patch for yum packages.py
repodiff-clogdelta.patch (1.5 kB) - added by mschwendt on 12/19/08 13:55:35.
patch for yum-utils repodiff

Change History

12/19/08 13:54:59 changed by mschwendt

  • attachment packages.diff added.

patch for yum packages.py

12/19/08 13:55:35 changed by mschwendt

  • attachment repodiff-clogdelta.patch added.

patch for yum-utils repodiff

12/19/08 19:18:37 changed by james

  • owner changed from skvidal to james.
  • status changed from new to assigned.

As I said on f-d-l the yum-utils one is in upstream already ... the yum one is wrong though, just sorted should be removed (and reversed kept) or the changelog entries will be output backwards.

12/19/08 19:26:59 changed by mschwendt

Well, I've tested my patches. They work fine here. Note that the patch against yum.packages affects createrepo => you need to run the fully patched tools on fresh metadata.

06/09/09 13:51:43 changed by james

What is upstream now should be correct, the only remaining problem left is that there is no ordering guarantee for entries in .sqlite ... so we have to order by time when we load from there. For entries with the same time it's basically random if they come out in the correct order (ie. rpm order).

The only way I know of to fix this is to change createrepo to increment the timestamp by a second for entries which have the same timestamp as their predecessor. This would then need to be filtered out in yum, on load.

04/29/10 13:22:24 changed by skvidal

  • status changed from assigned to closed.
  • resolution set to fixed.

James: I believe you implemented the last comment, didn't you?

04/29/10 19:00:17 changed by james

Yeh, thanks for closing.